MusaMahmood/mcap
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

[0.1.39] gpu-bench: heap strings where temporary ones were freed, which crashed mcap when it reloaded the results

Browse Source
This commit is contained in:
Musa Mahmood 2026-10-18 19:33:43 -04:00
parent e66734cfad
commit f4595a6fdc
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
check_targets.jai
View File

@ -52,7 +52,7 @@ APP_NAME :: "mcap";
APP_FOLDER_NAME :: "mcap"; APP_FOLDER_NAME :: "mcap";
GIT_BRANCH :: "check"; GIT_BRANCH :: "check";
GIT_HASH :: "-"; GIT_HASH :: "-";
VERSION :: "0.1.38"; VERSION :: "0.1.39";
BUILD_DATE :: "-"; BUILD_DATE :: "-";
DEBUG :: true; DEBUG :: true;
COMPILE_TESTS :: true; COMPILE_TESTS :: true;

2
first.jai
View File

@ -8,7 +8,7 @@ APP_NAME :: "mcap";
APP_FOLDER_NAME :: "mcap"; APP_FOLDER_NAME :: "mcap";
APP_BUNDLE_IDENTIFIER :: "com.example.mcap"; APP_BUNDLE_IDENTIFIER :: "com.example.mcap";
VERSION :: "0.1.38"; VERSION :: "0.1.39";
// Where everything goes: bin/, or bin-headless/ for builds made with no_crash_dialog, so automated // Where everything goes: bin/, or bin-headless/ for builds made with no_crash_dialog, so automated
// builds never write over the ones you run by hand. // builds never write over the ones you run by hand.
build_directory := "bin"; build_directory := "bin";

2
tools/gpu_bench/gpu_bench.jai
View File

@ -359,7 +359,7 @@ run_task :: (task: *Task, prefer_gpu: bool, corpus: *Corpus) -> Run {
if prefer_gpu && run.provider != "CUDA" { if prefer_gpu && run.provider != "CUDA" {
// Said, and not timed: the CPU run, when asked for, is the same thing. // Said, and not timed: the CPU run, when asked for, is the same thing.
sampler_stop(); sampler_stop();
run.error = tprint("not on the GPU: %", run.explanation,, context.allocator); run.error = sprint("not on the GPU: %", run.explanation);
return run; return run;
} }

2
tools/gpu_bench/results.jai
View File

@ -69,7 +69,7 @@ bench_parse :: (text: string, path := "") -> Bench_Report, ok: bool, error: stri
} else if key == "model" { } else if key == "model" {
space := find_index_from_left(value, #char " "); space := find_index_from_left(value, #char " ");
if space < 0 continue; if space < 0 continue;
array_add(*report.header, .{tprint("model %", slice(value, 0, space),, context.allocator), copy_string(trim(advance(value, space + 1)))}); array_add(*report.header, .{sprint("model %", slice(value, 0, space)), copy_string(trim(advance(value, space + 1)))});
} else { } else {
array_add(*report.header, .{copy_string(key), copy_string(value)}); array_add(*report.header, .{copy_string(key), copy_string(value)});
} }